PolicyInsights RP GA version of cmdlets by bulentelmaci · Pull Request #6375 · Azure/azure-powershell

bulentelmaci · 2018-06-04T19:52:22Z

Description

PolicyInsights RP GA version of cmdlets:

Removed "preview"; update the version to 1.0.0.0
Update the .NET SDK to the GA version
Add the newly added attribute in the contract to the policy state summary model
Rerecord tests with changes to resource names
Fix a help text issue

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

…nto preview

…ording) * Upgrade PolicyInsights package to latest. * Add new property in the latest API version to the contract. * Limit recording size; change hardcoded resource names for re-recording

…nto preview

…mes from functions in common

…alidation

…tions/assignments

bulentelmaci · 2018-06-04T23:20:18Z

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/86

praries880 · 2018-06-05T00:02:56Z

src/ResourceManager/PolicyInsights/ChangeLog.md

 -->
 ## Current Release

+## Version 1.0.0


remove this... the version number will be added by the versioning tool, just leave the latest changes under Current Release

praries880 · 2018-06-05T20:51:26Z

@bulentelmaci can you add the policy insignts module as a required module in the AzureRM psd1.

We need this since the module is now going to be a BA module and needs to be packaged with AzureRM.

praries880 · 2018-06-05T20:53:35Z

...ourceManager/PolicyInsights/Commands.PolicyInsights.Test/Commands.PolicyInsights.Test.csproj

    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.10\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.11\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>


Microsoft.Rest.ClientRuntime, Microsoft.Rest.ClientRuntime.Azure and Newtonsoft.Json shouldn't be in the .csproj or packages.config files since they are referenced elsewhere.

For example, every .csproj file should have a reference to the following file at the bottom of their file

Here's an example of a .csproj file referencing this file

praries880 · 2018-06-05T20:54:16Z

src/ResourceManager/PolicyInsights/Commands.PolicyInsights.Test/packages.config

@@ -13,8 +13,8 @@
  <package id="Microsoft.Data.Services.Client" version="5.6.4" targetFramework="net45" />
  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
  <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net452" />
-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />
-  <package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.10" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.11" targetFramework="net452" />


Microsoft.Rest.ClientRuntime, Microsoft.Rest.ClientRuntime.Azure and Newtonsoft.Json shouldn't be in the .csproj or packages.config files since they are referenced elsewhere.

For example, every .csproj file should have a reference to the following file at the bottom of their file

Here's an example of a .csproj file referencing this file

praries880 · 2018-06-05T20:54:29Z

src/ResourceManager/PolicyInsights/Commands.PolicyInsights/Commands.PolicyInsights.csproj

      <Private>True</Private>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.10\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.11\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>


Microsoft.Rest.ClientRuntime, Microsoft.Rest.ClientRuntime.Azure and Newtonsoft.Json shouldn't be in the .csproj or packages.config files since they are referenced elsewhere.

For example, every .csproj file should have a reference to the following file at the bottom of their file

Here's an example of a .csproj file referencing this file

praries880 · 2018-06-05T20:54:59Z

src/ResourceManager/PolicyInsights/Commands.PolicyInsights/packages.config

-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />
-  <package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.10" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.PolicyInsights" version="1.0.0" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.11" targetFramework="net452" />


Microsoft.Rest.ClientRuntime, Microsoft.Rest.ClientRuntime.Azure and Newtonsoft.Json shouldn't be in the .csproj or packages.config files since they are referenced elsewhere.

praries880 · 2018-06-05T21:13:06Z

on demand : https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/917/

…nto preview

…shell into preview

praries880 · 2018-06-06T17:28:43Z

@bulentelmaci you need to fix the version of the SDK library for the netcore csproj as well

…sights into AzureRM.Netcore PSD1

…nto preview

praries880 · 2018-06-06T21:58:34Z

src/ResourceManager/PolicyInsights/Commands.PolicyInsights.Test/ScenarioTests/Common.ps1


    Assert-NotNull $value
-	Assert-AreNotEqual $value ""
+	Assert-True { $value -ne "" }


Can you use :

[string]::IsNullOrEmpty(...)

Oh much better. Will do

praries880

@bulentelmaci just a minor nitpick… otherwise LGTM

bulentelmaci · 2018-06-07T15:43:37Z

@praries880 Good to go now?

praries880 · 2018-06-07T17:42:07Z

on demand :https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/919/

bulentelmaci added 14 commits May 24, 2018 10:45

Fix bug in help text for To parameter

937c683

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

bfa6d75

…nto preview

Upgrade PolicyInsights package to latest; test changes (needs new rec…

a709a17

…ording) * Upgrade PolicyInsights package to latest. * Add new property in the latest API version to the contract. * Limit recording size; change hardcoded resource names for re-recording

Version change; release notes and change log

58e63dd

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

943c40e

…nto preview

Update assembly and help versions as well

34b9da7

Update test project; update test scripts to get hardcoded resource na…

9042bf8

…mes from functions in common

Minor fix

99e52ce

Add format for PolicyDefinitionReferenceId

b86e238

Regenerate MDs using platyPS

65c7cd2

Fix common function

a45a85d

More test validation fixes

0e964ee

Recorded new tests with some changed resource names; minor fixes to v…

73ede6d

…alidation

Recorded tests again with changes to resource names for policy defini…

14f673c

…tions/assignments

azuresdkci added the needs-review label Jun 4, 2018

praries880 added the Cmdlet Review Required ⚠️ label Jun 5, 2018

praries880 reviewed Jun 5, 2018

View reviewed changes

Remove version number from changelog

1c93e69

praries880 requested a review from MiYanni June 5, 2018 16:59

praries880 assigned MiYanni Jun 5, 2018

praries880 removed the request for review from MiYanni June 5, 2018 17:02

praries880 assigned praries880 and unassigned MiYanni Jun 5, 2018

praries880 suggested changes Jun 5, 2018

View reviewed changes

praries880 assigned bulentelmaci and unassigned praries880 Jun 5, 2018

praries880 added needs-revision and removed needs-review labels Jun 5, 2018

bulentelmaci added the Policy Insights label Jun 5, 2018

bulentelmaci added needs-review and removed needs-revision labels Jun 5, 2018

MiYanni and others added 3 commits June 5, 2018 18:30

Merge branch 'preview' into preview

fb747c4

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

7c1345f

…nto preview

Merge branch 'preview' of https://github.com/bulentelmaci/azure-power…

5280973

…shell into preview

cormacpayne added needs-revision and removed Policy Insights needs-review labels Jun 6, 2018

Fix the dependency version and metadata for netcore

c7e05a4

bulentelmaci added needs-review and removed needs-revision labels Jun 6, 2018

praries880 added Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ labels Jun 6, 2018

bulentelmaci added 2 commits June 6, 2018 14:02

Change package version in netcore test project as well; add policy in…

325c523

…sights into AzureRM.Netcore PSD1

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

1f7606b

…nto preview

praries880 reviewed Jun 6, 2018

View reviewed changes

praries880 previously approved these changes Jun 6, 2018

View reviewed changes

Use string.IsNullOrEmpty instead

34eb29a

bulentelmaci dismissed praries880’s stale review via 34eb29a June 6, 2018 22:48

Merge branch 'preview' into preview

d120a3d

praries880 approved these changes Jun 7, 2018

View reviewed changes

praries880 added Waiting for On Demand and removed needs-review Waiting for On Demand labels Jun 7, 2018

praries880 merged commit 8f20059 into Azure:preview Jun 7, 2018

Conversation

bulentelmaci commented Jun 4, 2018

Description

Checklist

Uh oh!

bulentelmaci commented Jun 4, 2018

Uh oh!

praries880 Jun 5, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 commented Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praries880 Jun 5, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 Jun 5, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 Jun 5, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 Jun 5, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 commented Jun 5, 2018

Uh oh!

praries880 commented Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praries880 Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulentelmaci Jun 6, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 left a comment

Choose a reason for hiding this comment

Uh oh!

bulentelmaci commented Jun 7, 2018

Uh oh!

praries880 commented Jun 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

praries880 commented Jun 5, 2018 •

edited

Loading

praries880 commented Jun 6, 2018 •

edited

Loading

praries880 Jun 6, 2018 •

edited

Loading